Replace cantonese g2p with "ToJyutping" #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks! |
|
The pyjyutping package is outdated and unmaintained, with many notable errors. https://github.com/CanCLID/ToJyutping is actively maintained by us and is the state-of-the-art jyutping converter right now. |
|
@RVC-Boss Hi, is there any update for this PR? We would like to improve the model's Cantonese performance based on the changes in this PR. Thank you! |
Tested correctly, I merged it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, suggest replacing the pyjyutping package with the latest Cantonese G2P package 'ToJyutping' to achieve higher accuracy.
More information: https://github.com/CanCLID/ToJyutping