-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/icons consistent #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rosannamilner Thanks Rosanna. I'm a big fan of the icons, but I've requested a review from @twinkarma too to get his opinion.
Also, could you please merge the latest dev into this branch / resolve the conflicts before merging into dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, thanks!
@rosannamilner are you happy for this to be merged? |
Yes, thanks Twin. However, the buttons inside the survey (svelte files) haven't had logos added to them as I'm still working that out, not being familiar to svelte. In base.html they're added like this below, how would I add boxicons package to svelte?
I can see in
|
Boxicon package has already been included both on the main site (in base.html) or in the test harness (in /assets/sort-survey-configurator/index.html). You might not be seeing an update when viewing the site itself as when you make a change in the sort-survey-configurator project you need to go in to the folder Sorry it's a bit convoluted at the moment, I'll be looking into how we can streamline the build process (or at least document it better) soon! |
Ah ok I see great, thanks! I'll aim to add them later and let you know when this PR is fully ready |
I have run out of time before the feedback session tomorrow to do much more but the internal survey buttons have been given icons now:
So this PR is ready @twinkarma for now if you're happy with these few missing icons! |
It's looking really good, I think we'll be ok missing a few icons. Thanks so much @rosannamilner! |
Closes #76
Added lots of icons! Let me know what you think
Notes