Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hipSOLVER syevj_batched memory leak #176

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix hipSOLVER syevj_batched memory leak #176

merged 1 commit into from
Oct 28, 2024

Conversation

MKKnorr
Copy link
Collaborator

@MKKnorr MKKnorr commented Oct 25, 2024

Fix memory leak and move the allocation out of the loop

@MKKnorr MKKnorr requested a review from dgaliffiAMD as a code owner October 25, 2024 12:50
dgaliffiAMD
dgaliffiAMD approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@dgaliffiAMD dgaliffiAMD merged commit 3e9cac6 into develop Oct 28, 2024
6 of 8 checks passed
@dgaliffiAMD dgaliffiAMD deleted the fix-hipsolver-syevj-batched branch October 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgaliffiAMD dgaliffiAMD dgaliffiAMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MKKnorr @dgaliffiAMD