Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source format linting to the GitHub workflows #140

Merged
merged 18 commits into from
Jul 17, 2024
Merged

Add source format linting to the GitHub workflows #140

merged 18 commits into from
Jul 17, 2024

Conversation

Mustaballer
Copy link
Contributor

@Mustaballer Mustaballer commented Jul 12, 2024 •
edited
Loading

Work on standardizing git-clang-format for both pre-commit hooks and CI checks to avoid discrepancies.

@Mustaballer Mustaballer requested a review from dgaliffiAMD as a code owner July 12, 2024 15:12
@Mustaballer Mustaballer marked this pull request as draft July 12, 2024 15:15
@Mustaballer
Copy link
Contributor Author

@dgaliffiAMD Ready for review!

@Mustaballer Mustaballer requested review from emankov and Beanavil July 13, 2024 02:22
@dgaliffiAMD dgaliffiAMD changed the title Add additional linting in the GitHub workflows Add source format linting to the GitHub workflows Jul 13, 2024
@dgaliffiAMD dgaliffiAMD added the continuous integration changes to workflows label Jul 13, 2024
dgaliffiAMD
dgaliffiAMD requested changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mustaballer. I'll test it out on my system, but I've made some notes for now.

example.cpp Outdated Show resolved Hide resolved
Scripts/CodeFormat/check_format.sh Show resolved Hide resolved
@dgaliffiAMD dgaliffiAMD marked this pull request as ready for review July 13, 2024 02:31
@Mustaballer Mustaballer marked this pull request as draft July 15, 2024 17:04
@Mustaballer Mustaballer requested a review from dgaliffiAMD July 15, 2024 19:21
@Mustaballer Mustaballer marked this pull request as ready for review July 15, 2024 19:27
@Mustaballer Mustaballer requested a review from Beanavil July 16, 2024 14:33
dgaliffiAMD
dgaliffiAMD approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Mustaballer Mustaballer merged commit 92786e2 into develop Jul 17, 2024
4 checks passed
@dgaliffiAMD dgaliffiAMD deleted the additional-linting-github-workflows branch September 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beanavil Beanavil Beanavil approved these changes

@dgaliffiAMD dgaliffiAMD dgaliffiAMD approved these changes

@emankov emankov Awaiting requested review from emankov

Assignees
No one assigned
Labels
continuous integration changes to workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mustaballer @Beanavil @dgaliffiAMD