Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Stream: repeating unique GUIDs in filter files #137

Merged

Conversation

Beanavil
Copy link
Collaborator

@Beanavil Beanavil commented Jul 4, 2024

The filter GUIDs for Source, Header and Resource files should be unique. This PR fixes duplicated GUIDs along the VS filter files and adds a Python script to check the uniqueness of said GUIDs.

@Beanavil Beanavil requested a review from dgaliffiAMD as a code owner July 4, 2024 16:21
@Beanavil Beanavil force-pushed the repeating_unique_guids_in_filter_files branch from ad2d782 to 3b4d6e6 Compare July 5, 2024 15:22
@dgaliffiAMD dgaliffiAMD merged commit a24a1b7 into ROCm:develop Jul 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants