Starting to add packaging support #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Galiffi <[email protected]>
Mustaballer
added a commit
that referenced
this pull request
Jul 17, 2024
|
I'm going to close this one, since it's being addressed in #143. |
Mustaballer
added a commit
that referenced
this pull request
Jul 29, 2024
…143) * copy changes from #131 * exclude binary, object and executable files * test "bin/*" exclusion * add build_packages.sh script to generate deb and rpm files from source * fix issues with rpm file generation * revert changes to CMakeLists.txt * add directive ective that prevents the RPM build process from terminating due to missing build ID * Set build_packages.sh to executable Signed-off-by: David Galiffi <[email protected]> * address PR review comments * Renamed 'packaging' to 'Packaging' To match casing of the other subfolders Signed-off-by: David Galiffi <[email protected]> * Refactor build script to accept PACKAGE_VERSION as a parameter and define PACKAGE_HOMEPAGE_URL variable for consistency in DEB and RPM packages. * disable the generation of debug packages * add PACKAGE_NAME, PACKAGE_VERSION, PACKAGE_INSTALL_PREFIX, BUILD_DIR as arguments and add default values * Add DEB_DIR and RPM_DIRas arguments Signed-off-by: David Galiffi <[email protected]> * Fix DEB package directory structure * Removed "PACKAGE_VENDOR" as it is not used. * Make RPM_*_DIR variables local to create_rpm_package * Refactor create_deb_package Using the "cat EOF" to create DEBIAN/control, rather than multiple "echo" statments. Similar to how the RPM spec files is generated. * Add DEB_PACKAGE_RELEASE and RPM_PACKAGE_RELEASE as arguments. * Create a STAGING_DIR contant Use "STAGING_DIR" constant rather than input parameter to helper functions. This matches the style of other constants being used, like BUILD_DIR and SOURCE_DIR * Print input variables Useful for build logs. * Remove the "clean up" at the end of the package generation. Artifacts can be used for debugging. * Add a log at each step * Fix linting errors found with "shellcheck" * Another linting issue. --------- Signed-off-by: David Galiffi <[email protected]> Co-authored-by: David Galiffi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal builds of the rocm-examples and inclusion of the rest of the ROCm deliverables.