Mark HIP specific headers with a warning.

ROCm · Oct 10, 2018 · b710acd · b710acd
1 parent 688cf17
commit b710acd
Show file tree

Hide file tree

Showing 12 changed files with 46 additions and 1 deletion.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -366,6 +366,8 @@ add_custom_command(TARGET clang_links POST_BUILD
 )
 
 # install certain LLVM libraries needed by HIP
+# TODO: why HIP needs this random soup is unclear; the HC specific passes are
+#       definitely not "certain LLVM libraries needed by HIP".
 install(PROGRAMS $<TARGET_FILE:LLVMAMDGPUDesc>
                  $<TARGET_FILE:LLVMAMDGPUUtils>
                  $<TARGET_FILE:LLVMMC>
@@ -374,7 +376,6 @@ install(PROGRAMS $<TARGET_FILE:LLVMAMDGPUDesc>
                  $<TARGET_FILE:LLVMPromotePointerKernArgsToGlobal>
                  $<TARGET_FILE:LLVMSelectAcceleratorCode>
                  $<TARGET_FILE:LLVMUndefineGlobalsInAcceleratorCode>
-                 $<TARGET_FILE:LLVMHello>
         DESTINATION lib
         COMPONENT compiler
 )

diff --git a/include/hc.hpp b/include/hc.hpp
@@ -12,6 +12,10 @@
 
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include "hc_defines.h"
 #include "kalmar_exception.h"
 #include "kalmar_runtime.h"

diff --git a/include/hc_am.hpp b/include/hc_am.hpp
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include "hc.hpp"
 #include <cstddef>
 #include <mutex>

diff --git a/include/hc_am_internal.hpp b/include/hc_am_internal.hpp
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include "hc_am.hpp"
 
 namespace hc {

diff --git a/include/hc_defines.h b/include/hc_defines.h
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 // C++ headers
 #include <algorithm>
 #include <cassert>

diff --git a/include/hc_math.hpp b/include/hc_math.hpp
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include "hc.hpp"
 #include <cmath>
 

diff --git a/include/hc_printf.hpp b/include/hc_printf.hpp
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include <type_traits>
 #include <cstdlib>
 #include <cstdio>

diff --git a/include/hc_rt_debug.h b/include/hc_rt_debug.h
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include <cstdlib>
 #include <cstdio>
 #ifndef USE_LIBCXX

diff --git a/include/hcc_features.hpp b/include/hcc_features.hpp
@@ -4,6 +4,10 @@
 //
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 //
 // If set, am_memtracker_update API accepts appPtr parm
 #define __HCC_HAS_EXTENDED_AM_MEMTRACKER_UPDATE (1)

diff --git a/include/kalmar_aligned_alloc.h b/include/kalmar_aligned_alloc.h
@@ -7,6 +7,10 @@
 
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include <cassert>
 #include <memory>
 #include <stdlib.h>

diff --git a/include/kalmar_exception.h b/include/kalmar_exception.h
@@ -7,6 +7,10 @@
 
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include <string>
 #include <exception>
 

diff --git a/include/kalmar_runtime.h b/include/kalmar_runtime.h
@@ -1,5 +1,9 @@
 #pragma once
 
+#if !defined(__HIPCC__)
+  #warning "This header is only intended for HIP usage, and not for direct inclusion."
+#endif
+
 #include "hc_defines.h"
 #include "kalmar_aligned_alloc.h"