Docs: Add xnack to unified memory page #3732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeljo-amd
requested review from
chrispaquot,
gandryey,
saleelk,
mangupta and
rakesroy
as code owners
adeljo-amd
force-pushed
the
docs-xnack
branch
from
7cc8f4b to
bb25693
Compare
neon60
approved these changes
Jan 29, 2025
MKKnorr
reviewed
Jan 29, 2025
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
adeljo-amd
force-pushed
the
docs-xnack
branch
2 times, most recently
from
0498b4d to
5931eb6
Compare
MKKnorr
reviewed
Jan 29, 2025
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
adeljo-amd
force-pushed
the
docs-xnack
branch
from
5931eb6 to
ed1171a
Compare
MKKnorr
approved these changes
Jan 29, 2025
randyh62
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Fir line 13:
space and dedicated physical memory backing it up, for example normal RAM for CPUs and
There was a problem hiding this comment.
For line 49:
the host or another device, on which the memory is located. The page is then
| XNACK | ||
| ----- | ||
|
|
||
| On specific GPU architectures (which is referenced in the previous table), there is an |
There was a problem hiding this comment.
Suggested change
| On specific GPU architectures (which is referenced in the previous table), there is an | |
| On specific GPU architectures (referenced in the previous table), there is an |
| Depending on the system, page migration may be disabled by default in which case managed | ||
| memory will act like pinned host memory and suffer degraded performance. | ||
|
|
||
| **XNACK** describes the GPU's ability to retry memory accesses that failed due to a page fault |
There was a problem hiding this comment.
Although it is footnoted in the previous table, I would add here that you need to enable XNACK ability by setting XNACK=1 environment variable.
| Name: amdgcn-amd-amdhsa--gfx90a:sramecc+:xnack- | ||
|
|
||
| Here, ``xnack-`` means that XNACK is available but is disabled by default. | ||
| Turning on XNACK by setting the environment variable ``HSA_XNACK=1`` gives |
There was a problem hiding this comment.
Here it says that XNACK is enabled with HSA_XNACK=1, but up above it is simply XNACK=1. Which is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sub-section about XNACK (along with a small example) to the
unified_memory.rstpage.