Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

メモリ使用量送信毎にcontextIdが強制的に書き換わっていた問題を修正 #50

Merged
merged 1 commit into from
Sep 5, 2020
Merged

メモリ使用量送信毎にcontextIdが強制的に書き換わっていた問題を修正 #50

merged 1 commit into from
Sep 5, 2020

Conversation

mizdra
Copy link
Member

@mizdra mizdra commented Sep 5, 2020

ref: #33

本来であれば contextId はページがロードされた時にだけ生成され直されるIdであったが、実装にミスがあってメモリ使用量を送信する際に毎回生成され直されるようになっていた。

@mizdra mizdra merged commit f15f357 into master Sep 5, 2020
@mizdra mizdra deleted the fix-context-id branch September 5, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mizdra