count が何故か 2191 or 0 で固定されて集計されてしまう問題を修正
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizdra
commented
Sep 5, 2020
| this.currentState = { | ||
| // NOTE: Vue の data は getter を使って構成されているので、プロパティにアクセスするタイミングによって値が変わってしまう。 | ||
| // これでは集計上不都合なので、ここで一度 pure なオブジェクトに変換している。 | ||
| this.currentState = JSON.parse(JSON.stringify({ |
There was a problem hiding this comment.
Vueのobserverが悪さしているのかな〜と思って、送信するデータを丸ごと JSON.parse(JSON.stringify(...)) するようにしてみた
mizdra
commented
Sep 5, 2020
Comment on lines
+85
to
+86
| // Infinity は JSON に変換できないので -1 として扱う | ||
| maxLoop: newState.configInUse?.maxLoop === Infinity ? -1 : (newState.configInUse?.maxLoop ?? this.currentState.configInUse.maxLoop), |
There was a problem hiding this comment.
ついでに無限ループがONだと集計の送信に失敗するバグがあったので直しておいた
mizdra
commented
Sep 5, 2020
| @@ -160,7 +164,7 @@ class MemoryMeasurementScheduler { | |||
|
|
|||
| const scheduleMeasurement = () => { | |||
| const interval = measurementInterval() | |||
| console.log('Scheduling memory measurement in ' + Math.round(interval / 1000) + ' seconds.') | |||
| console.log(`Scheduling memory measurement in ${Math.round(interval / 1000)} seconds (${new Date(Date.now() + interval).toLocaleString()}).`) | |||
There was a problem hiding this comment.
今はN秒後に performance.measureMemory が発火する、というログしかだしていないけど、これだと何時何分くらいに発火するのかパッと分からなくてデバッグ時に不便なので、ついでに時刻の形式で表示するようにしてみた。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #33
countが何故か 2191 or 0 で固定されて集計されてしまっている