Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline loads Ghost from RMDO GitLab instead of GitHub #1

Open
astares opened this issue Dec 18, 2020 · 3 comments
Open

Baseline loads Ghost from RMDO GitLab instead of GitHub #1

astares opened this issue Dec 18, 2020 · 3 comments

Comments

@astares
Copy link

astares commented Dec 18, 2020

The Baseline includes a dependency to Ghost project which seems to be loaded from an internal RMDO GitLab server

spec
   baseline: 'Ghost'
   with: [ spec repository: 'gitlab://gitlab.inria.fr:RMOD/Ghost' ].

should we not better use https://github.com/pharo-ide/Ghostinstead?

image

@adri09070
Copy link
Contributor

The project uses a Ghost version from RMOD Gitlab server that uses proxies that aren't in the github repo.

This is used by the overlay experimental package that is not finished anyway.

From what I saw, it uses 2 proxies and ghost is broken (from what I see from the tests) so maybe we should use something else that implements proxies, @guillep ?

@guillep
Copy link
Collaborator

guillep commented Sep 23, 2022

I personally would remove all experimental code. It can be left in another branch.
If the overlay thingy is not working, better remove it from the main branch, and remove the ghost dependency.

If somebody needs to resuscitate the overlay experiment, the code is in the repository history.

Thoughts?

@adri09070
Copy link
Contributor

Maybe we can do that.

I will resuscitate the overlay experiment. This is something that Steven wants me to do: allowing the interpreter to save states of a program to come back to it later. (It took me long enough to realize that what I was searching for was in this experimental package). Steven also wants me to find an equivalence between the DAST interpreter and the bytecode interpreter to be able to switch interpreters (in the debugger notably)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants