Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable arm64 Docker builds #112

Closed
wants to merge 36 commits into from
Closed

enable arm64 Docker builds #112

wants to merge 36 commits into from

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Feb 9, 2024

closes #104

Use a base image that has arm64 versions available and do not explicitly set the platform to amd64

RStudio and tidyverse provided by rocker/tidyverse and rocker/rstudio are not strictly necessary (necessary tidyverse R packages are installed anyway as dependencies).
https://hub.docker.com/r/rocker/r-ver/tags

closes #104 

Use a base image that has arm64 versions available and do not explicitly set the platform to amd64

RStudio and tidyverse provided by rocker/r-ver are not strictly necessary...
https://hub.docker.com/r/rocker/r-ver/tags
@AlexAxthelm
Copy link
Collaborator

I've nearly got the build process for multiarch builds in workflow.pacta. (RMI-PACTA/workflow.pacta#41). Suggest pausing this one until that's working as intended.

@cjyetman
Copy link
Member Author

cjyetman commented Feb 9, 2024

I've nearly got the build process for multiarch builds in workflow.pacta. (RMI-PACTA/workflow.pacta#41). Suggest pausing this one until that's working as intended.

How is workflow.pacta relevant to this repo?

@AlexAxthelm
Copy link
Collaborator

Because when that gets resolved, we can use the same action to do CI builds on this repo (including arm64)

@cjyetman
Copy link
Member Author

cjyetman commented Feb 9, 2024

oh... but this PR isn't about a GH action, it's about running the Dockerfile using docker-compose up

@jdhoffa
Copy link
Member

jdhoffa commented Feb 12, 2024

I don't have context or understand the discussion here, so leave it to @AlexAxthelm to review.

@jdhoffa jdhoffa removed their request for review February 12, 2024 09:12
@cjyetman
Copy link
Member Author

@AlexAxthelm?

@cjyetman cjyetman marked this pull request as draft February 13, 2024 17:49
@cjyetman cjyetman removed the request for review from AlexAxthelm February 13, 2024 17:49
@cjyetman
Copy link
Member Author

holding in draft because getting/building arm64 linux R packages is still wonky

@cjyetman
Copy link
Member Author

closing this as arm64 linux binaries on Public Posit Package Manager is not on the short term roadmap: https://forum.posit.co/t/arm64-binary-packages-for-linux-in-posit-public-package-manager/178514

@cjyetman cjyetman closed this Apr 17, 2024
@cjyetman cjyetman deleted the enable-arm64-build branch April 17, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using a base image that has an arm64 version available
3 participants