Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: update emission intensity - auto re-size and remove built-in filters #42

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Feat: update emission intensity - auto re-size and remove built-in filters #42

merged 4 commits into from
Oct 4, 2024

Conversation

MonikaFu
Copy link
Contributor

@MonikaFu MonikaFu commented Oct 1, 2024 •
edited
Loading

Update emission intensity so that it is sized to the size of the div and it works with global filters.

@MonikaFu MonikaFu requested a review from jdhoffa October 1, 2024 12:37
jdhoffa
jdhoffa approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks good to me, but can you please update the title and description of this PR?

A refactor doesn't actually change any functionality, this is in fact a feature, as you are adding new functionality to the output. :-)

@MonikaFu MonikaFu changed the title Refactor emission intensity Feat: update emission intensity - auto re-size and remove built-in filters Oct 4, 2024
@MonikaFu MonikaFu merged commit 6db96f1 into main Oct 4, 2024
4 of 5 checks passed
@MonikaFu MonikaFu deleted the refactor-emission-intensity branch October 4, 2024 15:20
@jdhoffa jdhoffa mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonikaFu @jdhoffa