Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emissions timeline adapts to selected scenario #125

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Dec 5, 2024

Allows the emissions intensity timeline plot to react to changes in the scenario and scenario source selectors.

  • requires new data_emissions.json that includes data for all scenario and scenario source combinations created with workflow.pacta.dashboard after add all scenarios to output of prep_emissions_trajectory() workflow.pacta.dashboard#40 merges (a preliminary example of that included in this PR at sample-data/data_emissions.json)
  • adapts appropriate event listeners in src/routes/sector_view.svelte to the retrigger the emissions timeline plot when the scenario or scenario source selector is changed
  • adapts the time_line.js to filter the data by scenario and scenario source also, and adds the currently selected scenario source to the legend label
Screenshot 2024-12-05 at 10 26 06

Copy link

github-actions bot commented Dec 5, 2024

Docker build status

commit_time git_sha image
2024-12-05T12:26:56Z d8e3602 ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-125

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this in coordination with RMI-PACTA/workflow.pacta.dashboard#40

and proved to myself that it works as expected.

However, @cjyetman I will need to push a styling PR to get CI to pass. Do you mind?

@cjyetman
Copy link
Member Author

cjyetman commented Dec 5, 2024

However, @cjyetman I will need to push a styling PR to get CI to pass. Do you mind?

go for it

@jdhoffa
Copy link
Member

jdhoffa commented Dec 5, 2024

Will do so after #130 is merged
(otherwise I'm gonna be formatting all of the sample-data which seems silly)

@jdhoffa jdhoffa marked this pull request as ready for review December 5, 2024 12:27
@jdhoffa jdhoffa requested a review from MonikaFu as a code owner December 5, 2024 12:27
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

70,000 LINES CHANGED!?
What is this a PR FOR GIANTS

@cjyetman
Copy link
Member Author

cjyetman commented Dec 5, 2024

70,000 LINES CHANGED!? What is this a PR FOR GIANTS

70,596 of it is a completely new sample data file which I mentioned in the description

total lines changed otherwise is 19

@jdhoffa I think you'll have to merge this to circumvent the code owner approval criteria?

@jdhoffa
Copy link
Member

jdhoffa commented Dec 5, 2024

70,000 LINES CHANGED!? What is this a PR FOR GIANTS

70,596 of it is a completely new sample data file which I mentioned in the description

ahaha i know I was just teasing!! :-)

@jdhoffa jdhoffa merged commit 4eb08d4 into main Dec 5, 2024
10 checks passed
@jdhoffa jdhoffa deleted the emission-timeline-adapts-to-selected-scenario branch December 5, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Emission intensity plot has a selectable scenario source and scenario
2 participants