-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emissions timeline adapts to selected scenario #125
Conversation
Docker build status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this in coordination with RMI-PACTA/workflow.pacta.dashboard#40
and proved to myself that it works as expected.
However, @cjyetman I will need to push a styling PR to get CI to pass. Do you mind?
go for it |
Will do so after #130 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
70,000 LINES CHANGED!?
What is this a PR FOR GIANTS
70,596 of it is a completely new sample data file which I mentioned in the description total lines changed otherwise is 19 @jdhoffa I think you'll have to merge this to circumvent the code owner approval criteria? |
ahaha i know I was just teasing!! :-) |
prep_emissions_trajectory()
workflow.pacta.dashboard#40Allows the emissions intensity timeline plot to react to changes in the scenario and scenario source selectors.
data_emissions.json
that includes data for all scenario and scenario source combinations created with workflow.pacta.dashboard after add all scenarios to output ofprep_emissions_trajectory()
workflow.pacta.dashboard#40 merges (a preliminary example of that included in this PR atsample-data/data_emissions.json
)src/routes/sector_view.svelte
to the retrigger the emissions timeline plot when the scenario or scenario source selector is changedtime_line.js
to filter the data by scenario and scenario source also, and adds the currently selected scenario source to the legend label