Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 trajectory_alignment - remove unreachable code #101

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Dec 2, 2024

Calls to return and break are superfluous (when you return you also automatically break), thus the break was unreachable code.

While I was there, I also handled a refactor commented by a TODO in the code.

@MonikaFu FYI

Relates to #96
Towards #29

@jdhoffa jdhoffa requested a review from MonikaFu as a code owner December 2, 2024 16:20
@jdhoffa jdhoffa requested a review from AlexAxthelm December 2, 2024 16:20
@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 2, 2024

The plot touched here was Volume Trajectory, so here is a side by side comparison to prove that the plots still generate as expected:

Before

Screenshot 2024-12-02 at 17 21 10

After

Screenshot 2024-12-02 at 17 21 49

(also checked with other sectors for good measure)
Screenshot 2024-12-02 at 17 22 20

@jdhoffa jdhoffa requested a review from cjyetman December 2, 2024 16:22
@jdhoffa jdhoffa merged commit 5e08a8f into main Dec 2, 2024
4 of 5 checks passed
@jdhoffa jdhoffa deleted the 29-linter-fix_unreachable_code branch December 2, 2024 16:30
@jdhoffa jdhoffa mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants