Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emission intensity plot has a selectable scenario source and scenario #41

Closed
MonikaFu opened this issue Sep 30, 2024 · 4 comments · Fixed by #125
Closed

feat: Emission intensity plot has a selectable scenario source and scenario #41

MonikaFu opened this issue Sep 30, 2024 · 4 comments · Fixed by #125
Assignees
Labels
ADO Also Tracked on Azure DevOps enhancement New feature or request

Comments

@MonikaFu
Copy link
Contributor

MonikaFu commented Sep 30, 2024

Currently we fix a scenario in the plot but because we now have global selectors it makes more sense to make it possible for the user to select a scenario they want to view in this plot.

AB#11938

@MonikaFu MonikaFu changed the title Emission intensity plot has a selectable scenario source and scenario feat: Emission intensity plot has a selectable scenario source and scenario Sep 30, 2024
@MonikaFu MonikaFu self-assigned this Sep 30, 2024
@MonikaFu MonikaFu added ADO Also Tracked on Azure DevOps enhancement New feature or request labels Sep 30, 2024
@MonikaFu
Copy link
Contributor Author

FYI @jdhoffa this is a new feature so I am not going to tackle it while re-sizing this plot and removing the filters but it should be added before we release the dashboard.

@cjyetman
Copy link
Member

This will likely require two main components:

  1. time_line.js will, at a minimum, need to be modified so that it filters the data by the selected scenario, e.g. here

    let subdata = data
    .filter((d) => d.asset_class == asset_class)
    .filter((d) => d.sector == sector)
    .filter((d) => d.allocation_translation == allocation_method)
    .filter((d) => d.equity_market == equity_market);

  2. workflow.pacta.dashboard will need a bespoke, modified version of pacta.portfolio.report:::prep_emissions_trajectory() that does not filter the data to one specific scenario defined by the select_scenario_other and/or select_scenario arguments.

@jdhoffa
Copy link
Member

jdhoffa commented Nov 28, 2024

@cjyetman are you able to handle the worfklow.pacta.dashboard portion of that?
do you have enough context to do so?

@cjyetman
Copy link
Member

@cjyetman are you able to handle the worfklow.pacta.dashboard portion of that?

do you have enough context to do so?

I think so. I'll give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Also Tracked on Azure DevOps enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants