-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
board/cpu: Import of STM32F3discovery (Cortex-M4) port #932
Conversation
|
||
/* turn all LEDs off */ | ||
LED_PORT->BRR = 0xff00; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check for missing newlines at the end of the files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newlines added...
I'll test if someone (@haukepetersen, @StefanPfeiffer) could lend me a board... |
#define TIMER_1_EN 1 | ||
// #define TIMER_2_EN 0 | ||
|
||
// Timer 0 configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line and following: replace //
to /* */
/** | ||
* @brief Send a signal to a given thread | ||
* | ||
* @param r TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs for ACK?
please rebase |
- Included a collection of cpu-dependent headers in core/include/arch - Extracted all interfaces that need to be implemented for a cpu - Created a mapping between those interfaces and the old ones Conflicts: core/include/lpm.h
just started the rebase - will take a little while... I'll let you know as soon as its done. |
rebased and fixed. @thomaseichinger could you test it on the target? Thx. |
It seems stm lib doesn't get downloaded automatically. $> cd RIOT/examples/hello-world
$> make clean all BOARD=stm32f3discovery
[...]
RIOT/cpu/stm32f303vc/include/cpu-conf.h:22:23: fatal error: stm32f30x.h: No such file or directory
#include "stm32f30x.h"
^
compilation terminated.
make[1]: *** [/Volumes/MacintoshHD/Users/thomaseichinger/code/RIOT/RIOT/examples/hello-world/bin/stm32f3discovery/stm32f3discovery_base/board.o] Error 1
make: *** [all] Error 2 |
INCLUDES += -I$(STM_LIB_BASE)lib/Libraries/CMSIS/Include | ||
INCLUDES += -I$(STM_LIB_BASE)lib/Libraries/CMSIS/Device/ST/STM32F30x/Include | ||
INCLUDES += -I$(STM_LIB_BASE)lib/Libraries/STM32F30x_StdPeriph_Driver/inc | ||
INCLUDES += -I$(STM_LIB_BASE)lib/Project/STM32F30x_StdPeriph_Templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-INCLUDES += -I$(STM_LIB_BASE)lib/Project/STM32F30x_StdPeriph_Templates
+INCLUDES += -I$(STM_LIB_BASE)lib/Projects/STM32F30x_StdPeriph_Templates
with above changes it compiles for me but I don't get any output. |
I will close this PR, as it is outdated by #1191 and a upcoming PR for the STM32F0 - a new version of this PR build on the mentioned will follow. The new versions of the ports for the STM32 family are not dependent on the STM's standard peripheral library anymore which makes the resulting binary i) faster and ii) about 3kb smaller... |
Wasn't this PR your PR of the month? I'd call that cheating! ;) |
Finally here it is: a clean and working (as far as I tested it) port for the STM32F3discovery board. This might not be the end of the line as it can not be merged as is. But hopefully the dependencies can be merged in the near future so this PR can be merged as well.
It includes
The port is not working stand-alone, it is based on a bunch of open PRs, namely:
Initial import of low-level UART driver interface #613Initial import of low-level timer driver interface #614