Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better geo-point data error handling #307

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

PhillipsOwen
Copy link
Collaborator

@PhillipsOwen PhillipsOwen commented Oct 21, 2024

addresses Issue #306

better error handling/reporting textual error back to the user

also snuck in a change to the dialog title for geo-points

@PhillipsOwen PhillipsOwen requested a review from lstillwe October 21, 2024 19:01
@PhillipsOwen PhillipsOwen changed the title Better geo-point data erro handling Better geo-point data error handling Oct 21, 2024
@PhillipsOwen PhillipsOwen marked this pull request as draft October 22, 2024 11:47
@lstillwe
Copy link
Contributor

I would double check with @BrianOBlanton, but I don't think he wants the title "Water level at" for both Maximum Water Level and Maximum Significant Wave Height

@PhillipsOwen PhillipsOwen marked this pull request as ready for review October 22, 2024 13:31
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Axios retry - interesting.

@lstillwe lstillwe merged commit 11f47bf into main Oct 22, 2024
@lstillwe lstillwe deleted the issue-306-better-error-reporting branch October 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants