Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 257 - Default layer visibility handling when coming in/out of compare mode. #258

Closed
wants to merge 10 commits into from

Conversation

PhillipsOwen
Copy link
Collaborator

@PhillipsOwen PhillipsOwen commented Sep 26, 2024

adding functionality to hide currently selected layers and and restoring defaults when coming in/out of compare mode.

sorry about the inconsistent branch name. please merge and DO NOT DELETE the branch if the PR passes review.

Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous functionality works better. So I would not recommend these updates. I noticed you can add and delete layers while comparing. Previously functionality would jump out of compare if the user did that. You can delete one of the layers you are comparing and the compare still stays active.
We probably shouldn't worry about split screen hurricane layers - especially if it is causing issues. The user can always overlay hurricane tracks to see the differences - which you cant do with rasters.
Maybe we should revisit a change of functionality at some point. I think this branch should be preserved as a reference until then - it does have some neat updates.

@PhillipsOwen
Copy link
Collaborator Author

Closing this PR and renaming the branch name so it is retained.

@PhillipsOwen PhillipsOwen deleted the issue-227-s/s-hurricane branch September 27, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants