Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify cat_or_not-HeadhunterReupload-0.0.4 #47

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

catornot
Copy link
Member

@catornot catornot commented Feb 2, 2025

HeadhunterReupload v0.0.4

Did I read the whole README file and understood all of its content?

YES

Did I update verified-mods.json with my new mod's information?

YES

Has a previous version of my mod been previously verified?

NO

Mod description

A reupload of the Headhunter gamemode

Thunderstore link

https://thunderstore.io/c/northstar/p/cat_or_not/HeadhunterReupload/

@catornot
Copy link
Member Author

catornot commented Feb 2, 2025

:(

@catornot catornot marked this pull request as draft February 2, 2025 23:37
@catornot catornot marked this pull request as ready for review February 2, 2025 23:47
@Alystrasz Alystrasz added the verification request Request for verification label Feb 3, 2025
@Alystrasz
Copy link
Contributor

  • CI verification passes
  • Commit hash is OK
  • Checksum is OK
  • No malicious scripts inside mod itself, and no use of "dangerous" 1 functions

LGTM.

Footnotes

  1. e.g.: Safe I/O stuff and SquirrelHTTP. "dangerous" is a bit too much maybe. Under the assumption that the native implementations are correct and secure, there's nothing dangerous here. However it's always recommended to use more of a Swiss cheese approach and also operate a bit under the assumption that a layer can fail.

@Alystrasz Alystrasz merged commit 22bd9a4 into R2Northstar:main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verification request Request for verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants