Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improved Northstar cheatcommands #916

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Slightly improved Northstar cheatcommands #916

wants to merge 3 commits into from

Conversation

NachosChipeados
Copy link
Contributor

@NachosChipeados NachosChipeados commented Jan 15, 2025 •
edited
Loading

Couldn't think of a better title lol

  • Added "god" as a valid way to activate demigod
  • Changed prints to actually indicate when the effects get turned on or off
    Commands can now be triggered when using allcaps
Titanfall.2.2025-01-15.15-35-56.mp4

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 15, 2025
@Bobbyperson
Copy link
Contributor

tbh, I think allowing uppercase vs lowercase should be something handled globally, so that it's consistent with all other commands. curious what other people think though

@NachosChipeados
Copy link
Contributor Author

Fair point actually. I don't think any other concommand gets handled that way, so i might remove that part

@Bobbyperson
Copy link
Contributor

LGTM, hopefully gets merged soon

Zanieon
Zanieon approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay despite some whitespaces. Don't think this gonna need testing since it's still quite simple to get what it is doing.

@Zanieon Zanieon added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NachosChipeados @Bobbyperson @Zanieon