-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of Autohook from audio.cpp
#777
Conversation
Part of #778 |
audio.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok, however this isnt going to work in testing as mileswin64.dll
is imported by client.dll
and we only run callbacks for LoadLibrary*
calls. ( See this change in primedev: F1F7Y@368f660#diff-54ccaa9ecaf9f49dd1e7d51bfe382cb5025349aee6cd4a3003282314a99d19ad )
(Approved because this'll fail when testing, meh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @F1F7Y predicted, this breaks in testing.
Tested with https://thunderstore.io/c/northstar/p/FUZE/Replace_Background_Music_for_The_Lobby_with_Helldivers2_OST/
Without the PR the lobby music was overridden, with the PR it no longer was.
…ple times for the same module.
Fix manual hooks storing their name wrong and move to just using std::string since it's much more convenient and this isn't C
54aaad9
to
7c41e71
Compare
Now depends on #780 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working testing. My death sound audio override mod still worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes to code, fix is already on main. LGTM
Removes AUTOHOOK macros from `audio.cpp` and replaces them with `HookAttach`.
Trying to move towards manual hooks over macro hell, one file at a time.
Requires:
mileswin64.dll
) #780Code review:
o_p
so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.h_
so any times where we would be wanting to call the hooked function from other functions should now be calling that insteadTesting: