Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick changes from more recent RapidJSON to reduce warnings #646

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Cherry-pick changes from more recent RapidJSON to reduce warnings #646

merged 2 commits into from
Jan 21, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

ye

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 21, 2024
@GeckoEidechse GeckoEidechse changed the title Preport changes from more recent RapidJSON to reduce warnings Cherry-pick changes from more recent RapidJSON to reduce warnings Jan 21, 2024
GeckoEidechse
GeckoEidechse approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine from quick check. Only compilation related changes, so no testing needed.

Not gonna check if those changes are in upstream RapidJSON cause I trust you on that :P

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 21, 2024
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Jan 21, 2024 •
edited
Loading

oh damn, didn't see you even linked them in commit message lol. Nice :D

@GeckoEidechse GeckoEidechse merged commit e72f0cb into R2Northstar:main Jan 21, 2024
4 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the rapidjson-warnings branch February 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASpoonPlaysGames @GeckoEidechse