Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test fetchpriority option for link with modulepreload (DO NOT MERGE) #6832

Closed
wants to merge 211 commits into from
Closed

chore: test fetchpriority option for link with modulepreload (DO NOT MERGE) #6832

wants to merge 211 commits into from

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 27, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

As discussed in https://discord.com/channels/842438759945601056/1276861655833383034/1277680025398804491

TLDR: I need this PR to test modulepreload with fetchpriority to low on qwik UI on a production setup to see if it fixes FCP and LCP issues with modulepreload.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@maiieul maiieul requested review from a team as code owners August 27, 2024 12:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 54eb131

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
@builder.io/qwik-react Patch
@builder.io/qwik-worker Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 27, 2024 •
edited
Loading

commit: 54eb131

npm i https://pkg.pr.new/@builder.io/qwik@6832

npm i https://pkg.pr.new/@builder.io/qwik-city@6832

npm i https://pkg.pr.new/eslint-plugin-qwik@6832

npm i https://pkg.pr.new/create-qwik@6832

Open in Stackblitz

@maiieul maiieul closed this Aug 27, 2024
@maiieul maiieul force-pushed the test-fetchpriority-with-modulepreload-5 branch from 4e6fbbb to 83ff79d Compare August 27, 2024 12:28
@maiieul maiieul reopened this Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview fc9bc41

maiieul added 21 commits August 27, 2024 14:30
@maiieul
Revert "fix vite ecosystem - second try"
fdca300 
This reverts commit 22f54c5.
@maiieul
Revert "added governance doc"
4928b7d 
This reverts commit 89fbe78.
@maiieul
Revert "fixed build for vite ecosystem ci"
db6ee21 
This reverts commit 044dbe0.
@maiieul
Revert "docs: update index.mdx (QwikDev#6813)"
7dc01d8 
This reverts commit 477b5e0.
@maiieul
Revert "docs: add info about Link prefetch option (QwikDev#6814)"
def7e02 
This reverts commit cd1e68c.
@maiieul
Revert "fixed insights link"
b948bc7 
This reverts commit 072c38f.
@maiieul
Revert "docs: add new showcase site (QwikDev#6776)"
57b41bd 
This reverts commit cb69e99.
@maiieul
Revert "fix(qwik-city): Avoided unexpected caching for dynamic q-data (…
99be307 
…QwikDev#6797)"

This reverts commit 7adb75a.
@maiieul
Revert "docs: add Core api reference in the the menu (QwikDev#6792)"
c148852 
This reverts commit 6083989.
@maiieul
Revert "docs: update the location of the re-loader to be under /(qwik…
5ab562a 
…-cty) instead of /cookbook (QwikDev#6794)"

This reverts commit f7aef10.
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
17d2c7e 
…)"

This reverts commit ddcc489.
@maiieul
Revert "fix(repl): version detection (QwikDev#6791)"
89586ee 
This reverts commit 1583bb5.
@maiieul
Revert "fix(repl): version detection (QwikDev#6790)"
3c571a8 
This reverts commit 22920f2.
@maiieul
Revert "more descriptive"
49d9946 
This reverts commit 6f498cb.
@maiieul
Revert "changeset"
87f5aef 
This reverts commit 81854e4.
@maiieul
Revert "add preserve modules to lib starter"
5fa8895 
This reverts commit 4f4b094.
@maiieul
Revert "Revert "chore(docs): use prefetch service worker" (QwikDev#6786…
0f70576 
…)"

This reverts commit b6171cc.
@maiieul
Revert "fix(starter): update CLI version of storybook (QwikDev#6781)"
625c1d1 
This reverts commit 2175345.
@maiieul
Revert "Add sakenowa.com to showcase page (QwikDev#6779)"
0b31ffb 
This reverts commit 01c9d12.
@maiieul
Revert "Update index.mdx : "javascript" to "JavaScript" (QwikDev#6780)"
629a2ee 
This reverts commit 4c88089.
@maiieul
Revert "Version Packages"
3ea0738 
This reverts commit 5ddf269.
maiieul added 27 commits August 27, 2024 14:55
@maiieul
Revert "ci: delete .tgz files"
ed916bd 
This reverts commit 97ab0b2.
@maiieul
Revert "ci: delete root useless CHANGELOG 😊"
eb40e06 
This reverts commit 6296a6a.
@maiieul
Revert "ci: disable validate cli on windows"
492177b 
This reverts commit a1444ab.
@maiieul
Revert "ci: revert pnpm on validate cli"
64fc68b 
This reverts commit 329dbff.
@maiieul
Revert "ci: validate cli with pnpm"
91617f9 
This reverts commit 98da80e.
@maiieul
Revert "infra: made dev version explicit"
e1c6c1c 
This reverts commit 40d2e0e.
@maiieul
Revert "chore: added d.ts files to qwik"
f0cc22c 
This reverts commit c74da62.
@maiieul
Revert "fix(repl): correct import paths"
c41544d 
This reverts commit 155d1ba.
@maiieul
Revert "fix(optimizer): windows paths"
6f72ec7 
This reverts commit bc699c9.
@maiieul
Revert "perf(ci): more granular tests"
836eca2 
This reverts commit e80db7f.
@maiieul
Revert "chore: move qwik-city source under src"
60a3b27 
This reverts commit e7a91a3.
@maiieul
Revert "chore: use own package.json for all packages"
af02210 
This reverts commit 32daf72.
@maiieul
Revert "fix(vite-plugin): fix unresolved import (QwikDev#6713)"
8df1afc 
This reverts commit a6f88fd.
@maiieul
Revert "infra: changesets peer deps"
f604f9f 
This reverts commit 94c0c51.
@maiieul
Revert "fix(ci): correct fail/success calculations (QwikDev#6707)"
6151658 
This reverts commit b0802ca.
@maiieul
Revert "fix(ci): fail requirements on failure/cancellation"
6aaa233 
This reverts commit 314cc9a.
@maiieul
Revert "fix(docs): use Link for search results"
82dfc0b 
This reverts commit 1d79edb.
@maiieul
Revert "refactor(ci): move cloudflare build to separate job"
1d34920 
This reverts commit 517719b.
@maiieul
Revert "fix(dev): entry.ts routes"
d1ffdbf 
This reverts commit 71c0c24.
@maiieul
Revert "fix(qwikcity dev): do not serve dist/ during dev"
18cffef 
This reverts commit 5595af1.
@maiieul
Revert "fix(build): prod api extraction for qwik-city"
40dfb79 
This reverts commit 0b6752d.
@maiieul
Revert "fix(qwik-city): remove internal params in qdata"
1453b64 
This reverts commit 6a7e2f3.
@maiieul
Revert "tests(qwik-city,e2e,nav): Add a test case for QwikDev#6660"
123e859 
This reverts commit 4e1f31e.
@maiieul
Revert "fix(ci): print cloudflare summary in comments"
101e3c6 
This reverts commit e3c868c.
@maiieul
Revert "fix(changesets): version monorepo root"
a05368b 
This reverts commit 4f40c29.
@maiieul
Revert "docs(getting-started): remove reference to HMR (QwikDev#6686)"
4c2c964 
This reverts commit c69495b.
@maiieul
chore: test fetchpriority option for link with modulepreload (DO NOT …
54eb131 
…MERGE)
@maiieul maiieul force-pushed the test-fetchpriority-with-modulepreload-5 branch from fc9bc41 to 54eb131 Compare August 27, 2024 12:56
@maiieul
Copy link
Contributor Author

maiieul commented Aug 27, 2024

Going nowhere with this :/ Will try a different approach.

@maiieul maiieul closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maiieul