allows for explicit listing of tcl files on command line input #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On POSIX system had problem with Qutest where wildcard commands being expanded before being handed to Tcl and thus shifting out the remainder of the arguments.
ie: tclsh ~/qtools/qspy/tcl/qutest.tcl .tcl posix/test_dpp would not work unless quotations were placed around '.tcl', allowing Tcl's glob command to find matches.
This change allows for explicit listing at command line, meaning non-POSIX systems can list out one or more Tcl scripts without needing to use a wildcard. Or non-POSIX systems may continue using wildcards.
There is a small shortcoming in the implementation that we effectively cherry-pick all arguments ending in .tcl without regard to whether they are at the beginning. Not necessarily a bad thing... but maybe a little funky at least.