fix bounds error bug (#26)

* fix bounds error bu * Update test/linalg.jl
QuantumBFS · Oct 28, 2019 · a52bce4 · a52bce4
1 parent af024b1
commit a52bce4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/linalg.jl b/src/linalg.jl
@@ -129,8 +129,8 @@ function *(A::PermMatrix, X::SparseMatrixCSC)
     perm = fast_invperm(A.perm)
     nzval = similar(X.nzval)
     rowval = similar(X.rowval)
-    @inbounds for j = 1:nA
-        @inbounds @simd for k = X.colptr[j]:X.colptr[j+1]-1
+    @inbounds for j = 1:nX
+        @inbounds for k = X.colptr[j]:X.colptr[j+1]-1
             r = perm[X.rowval[k]]
             nzval[k] = X.nzval[k]*A.vals[r]
             rowval[k] = r

diff --git a/test/linalg.jl b/test/linalg.jl
@@ -92,3 +92,10 @@ end
         @test !(zm ≈ zeros(T,5,5))
     end
 end
+
+@testset "multiply rectangular matrix" begin
+    pm = pmrand(4)
+    sp = sparse(reshape([1.0 2 3 4], 4, 1))
+    res = pm * sp
+    @test res ≈ Matrix(pm) * Matrix(sp)
+end