Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster): enable karpenter for production #1809

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1410


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

@RemiBonnet RemiBonnet marked this pull request as ready for review January 20, 2025 16:55
Copy link

nx-cloud bot commented Jan 20, 2025

View your CI Pipeline Execution ↗ for commit 01aefa3.

Command Status Duration Result
nx affected --target=build --parallel=3 ✅ Succeeded 2m 37s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 1m 57s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 1m 56s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-22 08:59:14 UTC

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.

Project coverage is 53.51%. Comparing base (160bf58) to head (01aefa3).
Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...-resources-settings/cluster-resources-settings.tsx 27.27% 12 Missing and 4 partials ⚠️
...ture/step-general-feature/step-general-feature.tsx 16.66% 5 Missing ⚠️
...ge-clusters-create/step-features/step-features.tsx 33.33% 0 Missing and 2 partials ⚠️
...s/ui/card-cluster-feature/card-cluster-feature.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1809      +/-   ##
===========================================
- Coverage    53.52%   53.51%   -0.01%     
===========================================
  Files         1002     1002              
  Lines        13928    13937       +9     
  Branches      4035     4041       +6     
===========================================
+ Hits          7455     7459       +4     
- Misses        5073     5076       +3     
- Partials      1400     1402       +2     
Flag Coverage Δ
unittests 53.51% <24.24%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet force-pushed the feat/karpenter-production-FRT-1410 branch from d30a7ce to cc3a490 Compare January 22, 2025 08:40
@RemiBonnet RemiBonnet merged commit c388299 into staging Jan 22, 2025
12 checks passed
@RemiBonnet RemiBonnet deleted the feat/karpenter-production-FRT-1410 branch January 22, 2025 13:21
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.174.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant