Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-list): display deployment instead of service status for db managed #1805

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.slack.com/archives/C038JMN9GUE/p1736874206294889


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview e12a2902-8071-4d9f-aa36-7cbfb6252d14 feat/new-service-list-feedback-FRT-1301
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Make it work, make it right, make it fast

@RemiBonnet RemiBonnet marked this pull request as ready for review January 15, 2025 09:00
Copy link

nx-cloud bot commented Jan 15, 2025

View your CI Pipeline Execution ↗ for commit 70553f5.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ✅ Succeeded 3m 41s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 34s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 2m 8s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 09:05:54 UTC

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.48%. Comparing base (fa2d3a4) to head (70553f5).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...ices/feature/src/lib/service-list/service-list.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1805      +/-   ##
===========================================
+ Coverage    53.32%   56.48%   +3.16%     
===========================================
  Files          959      434     -525     
  Lines        13182     8057    -5125     
  Branches      3840     2403    -1437     
===========================================
- Hits          7029     4551    -2478     
+ Misses        4837     2636    -2201     
+ Partials      1316      870     -446     
Flag Coverage Δ
unittests 56.48% <50.00%> (+3.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet merged commit 08fe3a7 into staging Jan 15, 2025
12 checks passed
@RemiBonnet RemiBonnet deleted the fix/service-list-db-managed branch January 15, 2025 09:08
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.173.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant