Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service-list): feedback #1802

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Jan 3, 2025

What does this PR do?

https://qovery.slack.com/archives/C02NPSG2HBL/p1735553858212429


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Make it work, make it right, make it fast

Copy link

nx-cloud bot commented Jan 3, 2025

View your CI Pipeline Execution ↗ for commit 9705fc1.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ✅ Succeeded 3m 15s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 34s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 2m 30s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 14:25:23 UTC

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 17.39130% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.32%. Comparing base (f70cd61) to head (9705fc1).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../service-action-toolbar/service-action-toolbar.tsx 0.00% 11 Missing and 1 partial ⚠️
...d-gradient-text/animated-gradient-text.stories.tsx 0.00% 3 Missing ⚠️
...ment-action-toolbar/environment-action-toolbar.tsx 50.00% 2 Missing ⚠️
...ices/feature/src/lib/service-list/service-list.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1802      +/-   ##
===========================================
- Coverage    53.44%   53.32%   -0.13%     
===========================================
  Files          998      959      -39     
  Lines        13795    13182     -613     
  Branches      3986     3840     -146     
===========================================
- Hits          7373     7029     -344     
+ Misses        5042     4837     -205     
+ Partials      1380     1316      -64     
Flag Coverage Δ
unittests 53.32% <17.39%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet marked this pull request as ready for review January 6, 2025 15:35
@RemiBonnet RemiBonnet merged commit 359ceb6 into staging Jan 6, 2025
12 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-service-list-feedback-FRT-1301 branch January 6, 2025 16:28
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.173.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant