Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service-list): add new design #1799

Merged
merged 14 commits into from
Jan 2, 2025
Merged

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 24, 2024

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1301


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

Copy link

nx-cloud bot commented Dec 24, 2024

View your CI Pipeline Execution ↗ for commit 39c0ad5.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 55s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 55s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 2m 25s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-02 14:36:30 UTC

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 45 lines in your changes missing coverage. Please review.

Project coverage is 53.45%. Comparing base (c0a1910) to head (39c0ad5).
Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...ices/feature/src/lib/service-list/service-list.tsx 38.70% 17 Missing and 2 partials ⚠️
...ices/feature/src/lib/last-version/last-version.tsx 30.43% 16 Missing ⚠️
...rvices/feature/src/lib/last-commit/last-commit.tsx 14.28% 2 Missing and 4 partials ⚠️
...-template-indicator/service-template-indicator.tsx 0.00% 2 Missing ⚠️
.../service-action-toolbar/service-action-toolbar.tsx 50.00% 1 Missing ⚠️
...components/copy-to-clipboard/copy-to-clipboard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1799      +/-   ##
===========================================
+ Coverage    53.44%   53.45%   +0.01%     
===========================================
  Files          982      998      +16     
  Lines        13514    13790     +276     
  Branches      3916     3986      +70     
===========================================
+ Hits          7223     7372     +149     
- Misses        4938     5038     +100     
- Partials      1353     1380      +27     
Flag Coverage Δ
unittests 53.45% <31.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet marked this pull request as ready for review December 26, 2024 16:38
@RemiBonnet RemiBonnet merged commit f70cd61 into staging Jan 2, 2025
12 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-services-list-FRT-1301 branch January 2, 2025 14:39
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.172.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant