Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page-members): add member column count #1796

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.slack.com/archives/C02PGRVRMD2/p1733737131205719


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

@RemiBonnet RemiBonnet marked this pull request as ready for review December 19, 2024 17:17
Copy link

nx-cloud bot commented Dec 19, 2024

View your CI Pipeline Execution ↗ for commit b0a3531.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ✅ Succeeded 1m 20s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 1m 14s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 1m 5s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 17:21:01 UTC

@RemiBonnet RemiBonnet merged commit d9172a7 into staging Dec 19, 2024
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/members-page-add-count branch December 19, 2024 17:22
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.170.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.18%. Comparing base (c5246ab) to head (b0a3531).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1796      +/-   ##
===========================================
+ Coverage    53.52%   62.18%   +8.65%     
===========================================
  Files          997       75     -922     
  Lines        13741     1145   -12596     
  Branches      3969      328    -3641     
===========================================
- Hits          7355      712    -6643     
+ Misses        5012      321    -4691     
+ Partials      1374      112    -1262     
Flag Coverage Δ
unittests 62.18% <100.00%> (+8.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant