Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-modal): add value after creation input select value #1209

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1017


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I have followed the library pattern i.e feature, ui, data, utils
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

@RemiBonnet RemiBonnet force-pushed the feat/select-create-buttons-FRT-1017 branch from 817a0b5 to 24a62ce Compare February 27, 2024 15:00
Copy link

nx-cloud bot commented Feb 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ea3962f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet changed the title feat(create-modal): add value on the inpu select value feat(create-modal): add value after creation input select value Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 57.36%. Comparing base (13eb4b0) to head (ea3962f).
Report is 6 commits behind head on staging.

Files Patch % Lines
.../lib/git-provider-setting/git-provider-setting.tsx 14.28% 6 Missing ⚠️
.../feature/src/lib/source-setting/source-setting.tsx 0.00% 2 Missing ⚠️
...s-feature/cluster-credentials-settings-feature.tsx 33.33% 2 Missing ⚠️
...ntainer-settings/ui/general-container-settings.tsx 0.00% 2 Missing ⚠️
...dentials-settings/cluster-credentials-settings.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1209      +/-   ##
===========================================
- Coverage    57.53%   57.36%   -0.18%     
===========================================
  Files          597      598       +1     
  Lines         8518     8596      +78     
  Branches      2340     2367      +27     
===========================================
+ Hits          4901     4931      +30     
- Misses        2780     2818      +38     
- Partials       837      847      +10     
Flag Coverage Δ
unittests 57.36% <58.06%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet marked this pull request as ready for review February 27, 2024 15:38
@RemiBonnet RemiBonnet requested a review from ctjhoa February 27, 2024 15:38
Copy link
Contributor

@ctjhoa ctjhoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currenlty onClose doesn't take any param.
We can use it to return requests responses (either edit or create) as params.

@RemiBonnet RemiBonnet requested a review from ctjhoa February 28, 2024 13:42
@RemiBonnet RemiBonnet merged commit dce4704 into staging Feb 29, 2024
12 checks passed
@RemiBonnet RemiBonnet deleted the feat/select-create-buttons-FRT-1017 branch February 29, 2024 13:01
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.98.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants