Merge qiskit and qiskit-ecosystem theme implementation
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Dec 5, 2023
| @@ -42,7 +42,6 @@ | |||
| "sphinx.ext.autosummary", | |||
| "sphinx.ext.mathjax", | |||
| "sphinx.ext.viewcode", | |||
| "sphinx.ext.extlinks", | |||
There was a problem hiding this comment.
We weren't using this extension
| @@ -13,19 +13,8 @@ | |||
|
|
|||
| import { expect, test } from "@playwright/test"; | |||
|
|
|||
| import { click } from "./utils"; | |||
|
|
|||
| test("left side bar renders correctly", async ({ page }) => { | |||
There was a problem hiding this comment.
I keep this test around for now to make sure the ecosystem theme still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two themes are now equivalent and there is no longer an
/ecosystemfolder with overrides.A follow up PR will remove the
qiskittheme.Removes blue color code
This was only used for IBM Provider and IBM Runtime, which both now live at docs.quantum.ibm.com. We never wanted other projects to use the color scheme.
Technically projects can still override their color by changing
conf.py, since Furo itself allows that. But we don't advertise it for now.