Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce parallelism for qpy tests #13735

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mtreinish
Copy link
Member

Summary

In #13506 the QPY backwards compatibility tests are failing because the image is running out of disk space and github actions is killing the runner. The qpy files themselves should be fairly small and will be dwarfed by the virtual environments created to install old versions of qiskit to generate old QPY payloads. We use GNU parallel to speed up the testing, however by doing this we end up having multiple venvs at once which increases the disk space usage. This commit attempts to reduce the pressure on the disk space usage by decreasing the parallelism from N cpus (which is currently 4 for linux runners according to [1]) to 2. This will increase the runtime for this job but if we have insufficient disk space on the image to generate new qpy files there isn't really a choice.

Details and comments

[1] https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

In Qiskit#13506 the QPY backwards compatibility tests are failing because the
image is running out of disk space and github actions is killing the
runner. The qpy files themselves should be fairly small and will be
dwarfed by the virtual environments created to install old versions of
qiskit to generate old QPY payloads. We use GNU parallel to speed up the
testing, however by doing this we end up having multiple venvs at once
which increases the disk space usage. This commit attempts to reduce the
pressure on the disk space usage by decreasing the parallelism from N
cpus (which is currently 4 for linux runners according to [1]) to 2.
This will increase the runtime for this job but if we have insufficient
disk space on the image to generate new qpy files there isn't really
a choice.

[1] https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 25, 2025
@mtreinish mtreinish requested a review from a team as a code owner January 25, 2025 22:08
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12968822585

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 88.946%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 92.08%
crates/qasm2/src/lex.rs 3 92.48%
Totals Coverage Status
Change from base Build 12951053301: 0.005%
Covered Lines: 79442
Relevant Lines: 89315

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ran into the same issue when I added a qpy backwards compatibility test in #13727

@ElePT ElePT added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@mtreinish mtreinish added this pull request to the merge queue Jan 27, 2025
Merged via the queue into Qiskit:main with commit b718f06 Jan 27, 2025
17 checks passed
mergify bot pushed a commit that referenced this pull request Jan 27, 2025
In #13506 the QPY backwards compatibility tests are failing because the
image is running out of disk space and github actions is killing the
runner. The qpy files themselves should be fairly small and will be
dwarfed by the virtual environments created to install old versions of
qiskit to generate old QPY payloads. We use GNU parallel to speed up the
testing, however by doing this we end up having multiple venvs at once
which increases the disk space usage. This commit attempts to reduce the
pressure on the disk space usage by decreasing the parallelism from N
cpus (which is currently 4 for linux runners according to [1]) to 2.
This will increase the runtime for this job but if we have insufficient
disk space on the image to generate new qpy files there isn't really
a choice.

[1] https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

(cherry picked from commit b718f06)
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2025
In #13506 the QPY backwards compatibility tests are failing because the
image is running out of disk space and github actions is killing the
runner. The qpy files themselves should be fairly small and will be
dwarfed by the virtual environments created to install old versions of
qiskit to generate old QPY payloads. We use GNU parallel to speed up the
testing, however by doing this we end up having multiple venvs at once
which increases the disk space usage. This commit attempts to reduce the
pressure on the disk space usage by decreasing the parallelism from N
cpus (which is currently 4 for linux runners according to [1]) to 2.
This will increase the runtime for this job but if we have insufficient
disk space on the image to generate new qpy files there isn't really
a choice.

[1] https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

(cherry picked from commit b718f06)

Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants