Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show type hints in docs (backport #31) #34

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 7, 2024

Before, we would only show type hints for parameters that had dedicated docstring. There are a lot of parameters that don't have docstring—and sometimes don't need it because it's obvious—so it's best to no matter what show the docstring.

This PR aligns the autodoc templates and config with the other addons like cutting.


This is an automatic backport of pull request #31 done by Mergify.

Before, we would only show type hints for parameters that had dedicated docstring. There are a lot of parameters that don't have docstring—and sometimes don't need it because it's obvious—so it's best to no matter what show the docstring.

This PR aligns the autodoc templates and config with the other addons like cutting.

(cherry picked from commit a46b3d1)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11727699230

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11559143558: 0.0%
Covered Lines: 429
Relevant Lines: 429

💛 - Coveralls

@Eric-Arellano Eric-Arellano merged commit f0e337a into stable/0.1 Nov 7, 2024
15 checks passed
@Eric-Arellano Eric-Arellano deleted the mergify/bp/stable/0.1/pr-31 branch November 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants