ActionGroup-based serialization format for Orchard v6 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykoren
force-pushed
the
zsa-swap-tx-format-zsa1
branch
2 times, most recently
from
fb9e0a4 to
1e87dcf
Compare
This PR updates the orchard dependency used in librustzcash to a later version of our orchard repository fork
PaulLaux
reviewed
Jan 22, 2025
| ) | ||
| .unwrap(); | ||
|
|
||
| let binding = builder.mock_build_no_fee(OsRng).unwrap().into_transaction(); |
There was a problem hiding this comment.
can you brifly explain why we mock here?
There was a problem hiding this comment.
Just so we don't create a real Prover to save computational resources, because we don't test prover here, only builder
There was a problem hiding this comment.
I see. All the mock code is used explicitly in tests so it should be under #[test] tag somwhere. Please move it into #[test]
There was a problem hiding this comment.
Yes, this is the case already, all tests are under the test tag
PaulLaux
approved these changes
Jan 24, 2025
| ) | ||
| .unwrap(); | ||
|
|
||
| let binding = builder.mock_build_no_fee(OsRng).unwrap().into_transaction(); |
There was a problem hiding this comment.
I see. All the mock code is used explicitly in tests so it should be under #[test] tag somwhere. Please move it into #[test]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionGroup-based serialization format is implemented for Orchard v6