BUGFIX: Add logic for highspy versions #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbynum
approved these changes
Mar 7, 2025
jsiirola
reviewed
Mar 8, 2025
Comment on lines
+276
to
+277
| if self.version()[0] >= 1 and self.version()[1] >= 8: | ||
| self._solver_model.HandleKeyboardInterrupt = True |
There was a problem hiding this comment.
FWIW, there is a bug in this logic, as version 2.0 will not HandleKeyboardInterrupt. An improved implementation would be:
if self.version()[:2] >= (1, 8):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3489
Summary/Motivation:
There is a new feature in
highspythat allows keyboard interruption. It's not available in old versions. This PR checks the version to make sure it meets the minimum requirement.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: