Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync waitress-serve's docs with waitress.serve() #456

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

kgaughan
Copy link
Member

A number of options aren't documented on the command line interface. These settings are usable via waitress-serve already, but are not documented. The documentation is pulled from that of the waitress.serve() function.

See the comment raised by @merwok on #451.

A number of options aren't documented on the command line interface.
These settings are usable via waitress-serve already, but are not
documented.

See the comment raised by @merwok on Pylons#451.
@kgaughan kgaughan merged commit 2a1524a into Pylons:main Nov 23, 2024
38 checks passed
@kgaughan kgaughan deleted the sync-flags branch November 23, 2024 19:49

Default: ``1``

``--trusted_proxy_headers=LIST``
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that the option uses underscores, not hyphens?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed a mistake. I noticed it myself earlier, but I was working on something else, so haven't submitted a fix yet. If you want to submit the fix, go for it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#458 has the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants