Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove optional dependence on SciPy for FFT operations #791

Merged
merged 9 commits into from
Feb 3, 2025
+20 −48
Merged

MAINT: remove optional dependence on SciPy for FFT operations #791

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e7b80af
DEP: Drop installation of nightly SciPy
agriyakhetarpal Feb 1, 2025
6181b57
MAINT: Move `create_dat.py` to `util/` directory
agriyakhetarpal Feb 1, 2025
c31a47b
MAINT: Remove SciPy ref from manual + installation guide
agriyakhetarpal Feb 1, 2025
d7f52cc
STY: Fix usage of SciPy noun
agriyakhetarpal Feb 1, 2025
e847b6e
DEP, MAINT: Remove optional-dependencies table
agriyakhetarpal Feb 1, 2025
5bcef68
CI, MAINT: Remove SciPy-related CI options
agriyakhetarpal Feb 1, 2025
ed82b68
MAINT: don't opt for SciPy's FFT, use `numpy.fft`
agriyakhetarpal Feb 1, 2025
b8283af
STY: rename noGIL job to `linux-cp313t-default`
agriyakhetarpal Feb 1, 2025
7a692e7
STY: Remove `fftmodule` variable, use `np.fft`
agriyakhetarpal Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CI, MAINT: Remove SciPy-related CI options
@agriyakhetarpal
agriyakhetarpal committed Feb 1, 2025
commit 5bcef685d7d1657116132eaa7a39a15abc823292
11 changes: 0 additions & 11 deletions .github/workflows/tests.yml
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,6 @@ env:
CYTHONSPEC: cython
NUMPY_MIN: numpy==1.23.0
CYTHON_MIN: cython==3.0.4
SCIPY_MIN: scipy==1.9.0

jobs:
test_pywavelets_linux:
@@ -36,7 +35,6 @@ jobs:
runs-on: [ubuntu-latest] # Arm runner tested separately, see below
python-version: ["3.10", "3.13"]
MINIMUM_REQUIREMENTS: [0]
USE_SCIPY: [0]
USE_SDIST: [0]
REFGUIDE_CHECK: [1]
PIP_FLAGS: [""]
@@ -52,8 +50,6 @@ jobs:
OPTIONS_NAME: "minimum-req"
- runs-on: ubuntu-latest
python-version: "3.10"
USE_SCIPY: 1
OPTIONS_NAME: "with-scipy"
- runs-on: ubuntu-latest
python-version: "3.10"
USE_SDIST: 1
@@ -81,7 +77,6 @@ jobs:
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
OPTIONS_NAME: ${{ matrix.OPTIONS_NAME }}
run: |
@@ -97,11 +92,9 @@ jobs:
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest

@@ -190,7 +183,6 @@ jobs:
matrix:
python-version: ["3.10", "3.13"]
MINIMUM_REQUIREMENTS: [0]
USE_SCIPY: [0]
USE_SDIST: [0]
REFGUIDE_CHECK: [0]
PIP_FLAGS: [""]
@@ -219,7 +211,6 @@ jobs:
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
@@ -233,10 +224,8 @@ jobs:
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest