Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix central water tank storage source data #144

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

amos-schledorn
Copy link
Contributor

Closes # (if applicable).
#143

Changes proposed in this Pull Request

  • change sheet name for central water tank storage (TTES) from PTES_seasonal to Large hot water tank
  • update cost tables accordingly
  • note: this makes central water tank storage significantly more expensive but also more efficient

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@amos-schledorn amos-schledorn requested a review from fneum October 8, 2024 11:14
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Aligns with something I discussed with Tom yesterday. The plan is then to add PTES later?

@fneum fneum merged commit 2ae170f into master Oct 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants