Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary data correction file #1518

Closed
wants to merge 1 commit into from

Conversation

martacki
Copy link
Member

Closes # (if applicable).

Changes proposed in this Pull Request

delete the parameter_correction file that became redundant after the switch to OSM

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • [] A release note doc/release_notes.rst is added.

@martacki martacki requested a review from bobbyxng January 28, 2025 17:04
@martacki martacki self-assigned this Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • remove_param_corrections failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing remove_param_corrections (8a67b79) with master (e047c5e).
Branch is 1 commits ahead and 23 commits behind.
Last updated on 2025-01-28 18:08:30 CET.

@fneum
Copy link
Member

fneum commented Jan 29, 2025

The entsoegridkit can still be used by setting electricity: base_network: entsoegridkit. So while that is the case this file should not be removed.

@fneum fneum closed this Jan 29, 2025
@martacki martacki deleted the remove_param_corrections branch January 30, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants