Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add database name as the Connection attribute #752

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

cazorla19
Copy link
Contributor

This change will add self.database as the Connection attribute displaying the database name from connection parameters.

I've described the reason for this change in #751 . Moreover, I believe that this attribute can be useful for other use-case where the info about the database name can be useful.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (e2a908b) to head (ddc6675).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   88.86%   88.88%   +0.02%     
==========================================
  Files           7        7              
  Lines         548      549       +1     
==========================================
+ Hits          487      488       +1     
  Misses         61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@methane methane merged commit 8103651 into PyMySQL:main Jan 5, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants