Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating versions #957

Merged
merged 10 commits into from
Jan 30, 2025
Merged

Updating versions #957

merged 10 commits into from
Jan 30, 2025

Conversation

Pauan
Copy link
Collaborator

@Pauan Pauan commented Jan 23, 2025

This upgrades all of the NPM and Cargo versions. It has a couple other benefits:

  • It's no longer necessary to update the build.js file when adding a new export from Wasm.

  • The .wasm file size has been reduced from 8.9 megabytes to 7.3 megabytes (18% reduction).

    With opt-level = "z" the .wasm file size can be reduced down to 3.5 MB, but that's left for a future PR.

@Pauan Pauan force-pushed the fix/updating-versions branch from 147112e to 5206b2c Compare January 27, 2025 06:40
Copy link
Collaborator

@jaketarnow jaketarnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for working through all the updates @Pauan

Copy link
Collaborator

@iamalwaysuncomfortable iamalwaysuncomfortable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but asking a few questions so the rest of the maintainers are lucid about what's happening under the hood.

wasm/build.js Show resolved Hide resolved
wasm/build.js Show resolved Hide resolved
wasm/build.js Show resolved Hide resolved
wasm/build.js Show resolved Hide resolved
@Pauan Pauan force-pushed the fix/updating-versions branch from 2d32afc to 183d9e0 Compare January 30, 2025 01:10
@Pauan Pauan merged commit 2975260 into ProvableHQ:mainnet Jan 30, 2025
1 of 5 checks passed
@Pauan Pauan deleted the fix/updating-versions branch January 30, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants