Corrected isNewBuild structure and enhanced title of B5.1 (#125)

* correct is new build structure * corrected title by adding idemnity * indemnity
Property-Data-Trust-Framework · Nov 28, 2023 · 975e6b7 · 975e6b7
1 parent ab89965
commit 975e6b7
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 16 deletions.
diff --git a/src/schemas/v2/combined.json b/src/schemas/v2/combined.json
@@ -256,10 +256,14 @@
             },
             "isNewBuild": {
               "title": "Is the property a New Build?",
-              "yesNo": {
-                "type": "string",
-                "enum": ["Yes", "No"]
+              "type": "object",
+              "properties": {
+                "yesNo": {
+                  "type": "string",
+                  "enum": ["Yes", "No"]
+                }
               }
+
             },
             "location": {
               "title": "Geographical location",
@@ -22417,7 +22421,7 @@
                   "ta6Ref": "5.1",
                   "rdsRef": "Certificates",
                   "piqRef": "B5.1",
-                  "title": "Are there any valid guarantees or warranties relating to this property?",
+                  "title": "Are there any valid guarantees, warranties or indemnity insurances relating to this property?",
                   "type": "string",
                   "enum": ["Yes", "No"]
                 }

diff --git a/src/schemas/v2/overlays/baspi.json b/src/schemas/v2/overlays/baspi.json
@@ -9457,7 +9457,7 @@
               "properties": {
                 "hasValidGuaranteesOrWarranties": {
                   "baspiRef": "B5.1",
-                  "title": "Are there any valid guarantees or warranties relating to this property?",
+                  "title": "Are there any valid guarantees, warranties or indemnity insurances relating to this property?",
                   "enum": [
                     "Yes",
                     "No"

diff --git a/src/schemas/v2/overlays/piq.json b/src/schemas/v2/overlays/piq.json
@@ -3484,7 +3484,7 @@
               "properties": {
                 "hasValidGuaranteesOrWarranties": {
                   "piqRef": "B5.1",
-                  "title": "Are there any valid guarantees or warranties relating to this property?",
+                  "title": "Are there any valid guarantees, warranties or indemnity insurances relating to this property?",
                   "enum": [
                     "Yes",
                     "No"

diff --git a/src/schemas/v2/overlays/rds.json b/src/schemas/v2/overlays/rds.json
@@ -3471,7 +3471,7 @@
               "properties": {
                 "hasValidGuaranteesOrWarranties": {
                   "rdsRef": "Certificates",
-                  "title": "Are there any valid guarantees or warranties relating to this property?",
+                  "title": "Are there any valid guarantees, warranties or indemnity insurances relating to this property?",
                   "enum": [
                     "Yes",
                     "No"

diff --git a/src/schemas/v2/overlays/ta6.json b/src/schemas/v2/overlays/ta6.json
@@ -5114,7 +5114,7 @@
               "properties": {
                 "hasValidGuaranteesOrWarranties": {
                   "ta6Ref": "5.1",
-                  "title": "Are there any valid guarantees or warranties relating to this property?",
+                  "title": "Are there any valid guarantees, warranties or indemnity insurances relating to this property?",
                   "enum": [
                     "Yes",
                     "No"

diff --git a/src/schemas/v2/pdtf-transaction.json b/src/schemas/v2/pdtf-transaction.json
@@ -170,12 +170,15 @@
             },
             "isNewBuild": {
               "title": "Is the property a New Build?",
-              "yesNo": {
-                "type": "string",
-                "enum": [
-                  "Yes",
-                  "No"
-                ]
+              "type": "object",
+              "properties": {
+                "yesNo": {
+                  "type": "string",
+                  "enum": [
+                    "Yes",
+                    "No"
+                  ]
+                }
               }
             },
             "location": {
@@ -19586,7 +19589,7 @@
               "type": "object",
               "properties": {
                 "hasValidGuaranteesOrWarranties": {
-                  "title": "Are there any valid guarantees or warranties relating to this property?",
+                  "title": "Are there any valid guarantees, warranties or indemnity insurances relating to this property?",
                   "type": "string",
                   "enum": [
                     "Yes",

diff --git a/src/schemas/v2/skeleton.json b/src/schemas/v2/skeleton.json
@@ -35,7 +35,9 @@
       },
       "uprn": {},
       "propertyType": {},
-      "isNewBuild": {},
+      "isNewBuild": {
+        "yesNo": {}
+      },
       "location": {
         "latitude": {},
         "longitude": {},