vold: remove unused stop() methods

NetlinkManager::stop() and VolumeManager::stop() are never called, so remove them. Change-Id: I868aa2ad24066d2830816984afcc10000cbabad1
ProjectRadiant · Sep 23, 2020 · adba2fc · adba2fc
1 parent 5a99d3c
commit adba2fc
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 33 deletions.
diff --git a/NetlinkHandler.cpp b/NetlinkHandler.cpp
@@ -33,10 +33,6 @@ int NetlinkHandler::start() {
     return this->startListener();
 }
 
-int NetlinkHandler::stop() {
-    return this->stopListener();
-}
-
 void NetlinkHandler::onEvent(NetlinkEvent* evt) {
     VolumeManager* vm = VolumeManager::Instance();
     const char* subsys = evt->getSubsystem();

diff --git a/NetlinkHandler.h b/NetlinkHandler.h
@@ -25,7 +25,6 @@ class NetlinkHandler : public NetlinkListener {
     virtual ~NetlinkHandler();
 
     int start(void);
-    int stop(void);
 
   protected:
     virtual void onEvent(NetlinkEvent* evt);

diff --git a/NetlinkManager.cpp b/NetlinkManager.cpp
@@ -90,19 +90,3 @@ int NetlinkManager::start() {
     close(mSock);
     return -1;
 }
-
-int NetlinkManager::stop() {
-    int status = 0;
-
-    if (mHandler->stop()) {
-        PLOG(ERROR) << "Unable to stop NetlinkHandler";
-        status = -1;
-    }
-    delete mHandler;
-    mHandler = NULL;
-
-    close(mSock);
-    mSock = -1;
-
-    return status;
-}
diff --git a/NetlinkManager.h b/NetlinkManager.h
@@ -35,7 +35,6 @@ class NetlinkManager {
     virtual ~NetlinkManager();
 
     int start();
-    int stop();
 
     void setBroadcaster(SocketListener* sl) { mBroadcaster = sl; }
     SocketListener* getBroadcaster() { return mBroadcaster; }

diff --git a/VolumeManager.cpp b/VolumeManager.cpp
@@ -198,16 +198,6 @@ int VolumeManager::start() {
     return 0;
 }
 
-int VolumeManager::stop() {
-    CHECK(!mInternalEmulatedVolumes.empty());
-    for (const auto& vol : mInternalEmulatedVolumes) {
-        vol->destroy();
-    }
-    mInternalEmulatedVolumes.clear();
-
-    return 0;
-}
-
 void VolumeManager::handleBlockEvent(NetlinkEvent* evt) {
     std::lock_guard<std::mutex> lock(mLock);
 

diff --git a/VolumeManager.h b/VolumeManager.h
@@ -56,7 +56,6 @@ class VolumeManager {
     android::sp<android::os::IVoldListener> getListener() const { return mListener; }
 
     int start();
-    int stop();
 
     void handleBlockEvent(NetlinkEvent* evt);