Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Mementotlan Tatsunootoshigo" #1167

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

Satellaa
Copy link
Contributor

@Satellaa Satellaa commented Jan 4, 2025

Add early termination condition to stop checking combinations when duplicate names are detected, reducing unnecessary computations.

Bug fixed: If you destroy a level 9 Mementotlan monster and then choose any Mementotlan monster, it will cause the game to stall for a very long time.


New card checklist

  • I have submitted a corresponding database entry for BabelCDB according to its guidelines. Link to the pull request: fill in
  • This card is not marked with a reason to not be added in the unofficial card tracker in #card-scripting-101.
    Supervising staff member(s): fill in

Add early termination condition to stop checking combinations when duplicate names are detected, reducing unnecessary computations.
@Satellaa Satellaa requested a review from pyrQ as a code owner January 4, 2025 13:37
@Satellaa Satellaa changed the title Fixe "Mementotlan Tatsunootoshigo" Fix "Mementotlan Tatsunootoshigo" Jan 4, 2025
@NaimSantos NaimSantos merged commit 9e7116e into ProjectIgnis:master Jan 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants