-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement/issue 684 import meta resolve refactor part 2 #1341
Merged
thescientist13
merged 13 commits into
master
from
enhancement/issue-684-import-meta-resolve-refactor-part-2
Dec 13, 2024
Merged
enhancement/issue 684 import meta resolve refactor part 2 #1341
thescientist13
merged 13 commits into
master
from
enhancement/issue-684-import-meta-resolve-refactor-part-2
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
documentation
Greenwood specific docs
Plugins
Greenwood Plugins
CLI
labels
Dec 7, 2024
5 tasks
4 tasks
thescientist13
deleted the
enhancement/issue-684-import-meta-resolve-refactor-part-2
branch
December 13, 2024 17:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
unit testing, maintenance, etc
CLI
documentation
Greenwood specific docs
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
Plugins
Greenwood Plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #684 / #1313
See demos here
Summary of Changes
/~/
import.meta.resolve
throughout Greenwood (no hardcoded node_modules location assumptions 💯 )main
entry point to @greenwood/cli's package.json (so things like hashing utils and static router can get resolved withimport.meta.resolve
)import.meta.resolve
don't need to copy node_modules libs into test cases anymore (although still needed it for context / theme packs, but can look into those later)Documentation
public-hoist-pattern[]=@lit-labs/*
, wc-compiler for PNPM users/node_modules
vs bare specifiers, vs../../deep/path/to/file.css
import.meta.resolve
call out examplesERR_PACKAGE_PATH_NOT_EXPORTED
when package is called usingimport.meta.resolve
vercel/geist-font#150TODO
bin
only deps? - cannot reproducemain
entry point - https://unpkg.com/browse/[email protected]///
on wildcard specifiersimport.meta.resolve
, do we still need to copy node_modules libs into test cases anymore?getDependencyFiles
getSetupFiles