Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple file uploading, CORS #28

Merged
merged 1 commit into from
Jul 27, 2024
Merged

feat: multiple file uploading, CORS #28

merged 1 commit into from
Jul 27, 2024

Conversation

nsavinda
Copy link
Member

@nsavinda nsavinda commented Jul 27, 2024

Summary by CodeRabbit

  • New Features

    • Introduced CORS support to allow requests from specified origins, enhancing frontend and backend interaction.
    • Enhanced the file upload functionality to support multiple PDF uploads simultaneously, improving user experience and error handling.
  • Bug Fixes

    • Improved error handling for unsupported file types during multiple file uploads, ensuring clearer feedback for users.

Copy link

coderabbitai bot commented Jul 27, 2024

Walkthrough

The recent updates enhance the FastAPI application by introducing CORS support and improving the PDF upload functionality. CORS middleware allows requests from a specified frontend origin, while the upload endpoint now supports multiple file uploads, providing better error handling and logging. These changes improve the application's usability and flexibility, making it more suited for modern web development.

Changes

File Change Summary
app/main.py Added CORS middleware to handle cross-origin requests from a specified origin.
app/routers/upload.py Updated upload_pdf endpoint to support multiple file uploads, enhancing error handling and logging.

Sequence Diagram(s)

sequenceDiagram
    participant Frontend
    participant Backend
    participant CORS
    participant UploadHandler

    Frontend->>CORS: Send request for upload
    CORS->>Backend: Allow request from frontend
    Backend->>UploadHandler: Process file uploads
    UploadHandler->>UploadHandler: Validate files
    UploadHandler-->>Frontend: Return success or error message
Loading

🐇 In the code we hop and play,
With CORS to save the day!
Multiple PDFs now we can share,
With logs and checks, we show we care.
So let’s upload, it’s time to cheer,
Our app grows bright, the future’s near! 🌟


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nsavinda nsavinda merged commit 78dd53d into main Jul 27, 2024
1 check passed
@nsavinda nsavinda deleted the multiple_files branch July 27, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant