Skip to content

Commit

Permalink
fix for sonar warnings
Browse files Browse the repository at this point in the history
Signed-off-by: Neil South <[email protected]>
  • Loading branch information
neildsouth committed Jul 3, 2024
1 parent 0ed7285 commit 119f136
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/WorkflowManager/Storage/Services/DicomService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ public DicomService(IStorageService storageService, ILogger<DicomService> logger

public async Task<PatientDetails> GetPayloadPatientDetailsAsync(string payloadId, string bucketName)
{
ArgumentNullException.ThrowIfNullOrWhiteSpace(bucketName, nameof(bucketName));
ArgumentNullException.ThrowIfNullOrWhiteSpace(payloadId, nameof(payloadId));
ArgumentNullException.ThrowIfNullOrWhiteSpace(bucketName);
ArgumentNullException.ThrowIfNullOrWhiteSpace(payloadId);

var dict = await GetMetaData(payloadId, bucketName);

Expand All @@ -91,7 +91,7 @@ public async Task<PatientDetails> GetPayloadPatientDetailsAsync(string payloadId

private string? GetFirstValueAsync(Dictionary<string, DicomValue>? dict, string keyId)
{
ArgumentNullException.ThrowIfNullOrWhiteSpace(keyId, nameof(keyId));
ArgumentNullException.ThrowIfNullOrWhiteSpace(keyId);
if (dict is null)
{
return null;
Expand All @@ -117,8 +117,8 @@ public async Task<PatientDetails> GetPayloadPatientDetailsAsync(string payloadId

public async Task<Dictionary<string, DicomValue>?> GetMetaData(string payloadId, string bucketId)
{
ArgumentNullException.ThrowIfNullOrWhiteSpace(bucketId, nameof(bucketId));
ArgumentNullException.ThrowIfNullOrWhiteSpace(payloadId, nameof(payloadId));
ArgumentNullException.ThrowIfNullOrWhiteSpace(bucketId);
ArgumentNullException.ThrowIfNullOrWhiteSpace(payloadId);
var items = await _storageService.ListObjectsAsync(bucketId, $"{payloadId}/dcm", true);
var dict = new Dictionary<string, DicomValue>(StringComparer.OrdinalIgnoreCase);
try
Expand Down

0 comments on commit 119f136

Please sign in to comment.