Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Brain Image Synthesis Latent Diffusion from GenerativeModels to model-zoo #722

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from

Conversation

garciadias
Copy link

Fixes # No issue assigned

Description

This is part of the effort on deprecating GenerativeModels and having all models available in the model-zoo instead.

Status

Ready

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Virginia and others added 28 commits December 9, 2024 16:04
… longer necessary. On inference, modification of the entry point from save_jpg to run to allow for run to be called alone, and truncation of loading statements which are too long. Modification of the README to include command example changes.
For metadata, adjusted the versions, setting current to Initial Release. I also removed nibabel from the optional package requirements as this CXR produces JPG and does not deal with nifti files.
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names.

Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check.
Modification of large_files.yml so that models are .pt and not .pth.
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names.

Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check.
Modification of large_files.yml so that models are .pt and not .pth.
Modification of diffusion_model.pt name to model.pt to go through the verify_bundle Python function.
@virginiafdez
Copy link

@KumoLiu @ericspod Could you review this PR?

@KumoLiu KumoLiu requested a review from ericspod January 17, 2025 15:20
@KumoLiu KumoLiu requested review from Nic-Ma and KumoLiu January 17, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants